psa-systems/mokosh-server
Watch
9
0
Fork
You've already forked mokosh-server
 1
Code Issues Pull requests Projects Releases 10 Packages Wiki Activity Actions

fix(ci): create-release workflow concludes success on non-release merges #326

Merged
YousifShkara merged 1 commit from fix/ci-create-release-skip-conclusion into main 2026-06-21 07:44:39 +02:00
Conversation 0 Commits 1 Files changed 1 +28 -4
YousifShkara commented 2026-06-21 07:44:36 +02:00
Owner
Copy link

The workflow fires on every PR-closed event targeting main, but only a release/v* head ref should actually publish a release. The job-level if skipped the whole job on every non-release merge, which made the workflow conclude as skipped - the Forgejo repo status badge counted that as "not success" and the repo appeared red on the Actions overview even though every other workflow on the merge commit (check / e2e / integration / build-oci-image) was green. Replace the job-level gate with a step-level gate: an unconditional Gate step records do_release=true|false, and the two real steps gate on that output. The job always runs at least one step successfully and the workflow's conclusion is success whether or not a release publishes.

The workflow fires on every PR-closed event targeting main, but only a `release/v*` head ref should actually publish a release. The job-level `if` skipped the whole job on every non-release merge, which made the workflow conclude as `skipped` - the Forgejo repo status badge counted that as "not success" and the repo appeared red on the Actions overview even though every other workflow on the merge commit (check / e2e / integration / build-oci-image) was green. Replace the job-level gate with a step-level gate: an unconditional `Gate` step records `do_release=true|false`, and the two real steps gate on that output. The job always runs at least one step successfully and the workflow's conclusion is `success` whether or not a release publishes.
fix(ci): create-release workflow concludes success on non-release merges
All checks were successful
Create release / Create release from merged PR (pull_request) Successful in 1s
Details
E2E / Playwright against staging (pull_request) Successful in 35s
Details
Check / fmt + clippy + compile + unit/doc tests (pull_request) Successful in 1m15s
Details
Integration / integration tests (pull_request) Successful in 4m20s
Details
4d03d853cb 
The workflow fires on every PR-closed event targeting main, but only a `release/v*` head ref should actually publish a release. The job-level `if` skipped the whole job on every non-release merge, which made the workflow conclude as `skipped` - the Forgejo repo status badge counted that as "not success" and the repo appeared red on the Actions overview even though every other workflow on the merge commit (check / e2e / integration / build-oci-image) was green. Replace the job-level gate with a step-level gate: an unconditional `Gate` step records `do_release=true|false`, and the two real steps gate on that output. The job always runs at least one step successfully and the workflow's conclusion is `success` whether or not a release publishes.
YousifShkara deleted branch fix/ci-create-release-skip-conclusion 2026-06-21 07:44:39 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
YousifShkara
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/mokosh-server!326
No description provided.