fix(validation): reject inverted date ranges and oversized payment amounts #236

Merged

David merged 1 commit from fix/PMS-306-validation-date-range-money-overflow into main

2026-06-14 18:37:56 +02:00

David commented

2026-06-14 18:34:50 +02:00

Owner

Add cross-field and magnitude validation at the request layer so logically invalid create payloads return 422 instead of being persisted or surfacing as a 500 (PMS-306).

Contract create: reject end_date before start_date (open-ended and same-day ranges still allowed) via a struct-level schema validator.
Invoice create: reject due_date before invoice_date (same-day allowed) via a struct-level schema validator.
Payment create: bound amount to the DECIMAL(12, 2) column magnitude (|amount| < 10_000_000_000) so an oversized value (e.g. 1e15) returns a 422 rather than overflowing the column and surfacing as a 500 DATABASE_ERROR, same class as PMS-297. The new validate_money_amount helper lives in utils::validation alongside validate_contract_type.
Sign policy: payment amount and invoice line quantity / unit_price are intentionally signed (refunds, credits, discounts); documented in field docs and only the magnitude is constrained.

Adds DB-free unit tests covering each rule.

#PMS-306

Add cross-field and magnitude validation at the request layer so logically invalid create payloads return 422 instead of being persisted or surfacing as a 500 (PMS-306). - Contract create: reject end_date before start_date (open-ended and same-day ranges still allowed) via a struct-level schema validator. - Invoice create: reject due_date before invoice_date (same-day allowed) via a struct-level schema validator. - Payment create: bound amount to the DECIMAL(12, 2) column magnitude (|amount| < 10_000_000_000) so an oversized value (e.g. 1e15) returns a 422 rather than overflowing the column and surfacing as a 500 DATABASE_ERROR, same class as PMS-297. The new validate_money_amount helper lives in utils::validation alongside validate_contract_type. - Sign policy: payment amount and invoice line quantity / unit_price are intentionally signed (refunds, credits, discounts); documented in field docs and only the magnitude is constrained. Adds DB-free unit tests covering each rule. #PMS-306

David added 1 commit

2026-06-14 18:34:51 +02:00

fix(validation): reject inverted date ranges and oversized payment amounts

E2E / Playwright against staging (pull_request) Successful in 1m6s

Details

Check / fmt + clippy + compile + unit/doc tests (pull_request) Successful in 1m41s

Details

Create release / Create release from merged PR (pull_request) Has been skipped

Details

Integration / integration tests (pull_request) Successful in 8m41s

Details

8b5b99fb5b

Add cross-field and magnitude validation at the request layer so logically invalid create payloads return 422 instead of being persisted or surfacing as a 500 (PMS-306).

- Contract create: reject end_date before start_date (open-ended and same-day ranges still allowed) via a struct-level schema validator.
- Invoice create: reject due_date before invoice_date (same-day allowed) via a struct-level schema validator.
- Payment create: bound amount to the DECIMAL(12, 2) column magnitude (|amount| < 10_000_000_000) so an oversized value (e.g. 1e15) returns a 422 rather than overflowing the column and surfacing as a 500 DATABASE_ERROR, same class as PMS-297. The new validate_money_amount helper lives in utils::validation alongside validate_contract_type.
- Sign policy: payment amount and invoice line quantity / unit_price are intentionally signed (refunds, credits, discounts); documented in field docs and only the magnitude is constrained.

Adds DB-free unit tests covering each rule.

#PMS-306