chore(cleanup): remove dead crates code and stray config/seed/test cruft

David commented

2026-06-13 19:42:52 +02:00

Owner

Remove dead structs, traits, params, and config fields across the workspace crates, plus stray config, seed, migration-gap, and test cruft surfaced by the platform audit. No behavior change: every removed code item was dead (an unused export, an #[allow(dead_code)]-annotated helper, or a config field read only by a Debug impl).

Crates: drop the unused CurrentUser extractor; remove the NowOrDefault trait (callers use Clock::now directly); drop the unused _user_agent param on verify_only; remove _enforce_user_id_used and the unused UserId import in signup; delete the never-used RefreshTokenRow/RefreshFamilyRow rows and their From impls; drop the 4 dead AuthConfig bool fields and the now-unused parse_bool helper; drop the 3 dead EngineConfig TTL defaults; remove the superseded UserRepository::list_by_tenant and AuditLogger::list_recent; drop the unused _verifying_keys map; delete the never-constructed TicketActivity enum.

Stray: remove the dead ticket.sla_warning/ticket.sla_breach seed templates (no emitters); replace the hardcoded developer LAN IP in the demo script with a localhost default; add a 20260506000007_DELETED.md placeholder documenting the intentional auth-migrations gap (sqlx ignores non-.sql files); document multi-tenant-only tenancy in the README now that the single-tenant cargo feature is gone (PMS-262); provision an E2E_FOREIGN_COMPANY_ID fixture in global.setup.ts so the cross-tenant company canary runs unconditionally; remove the spurious same-file #[allow(dead_code)] annotations in the contacts and knowledge_base integration tests.

#PMS-202

Remove dead structs, traits, params, and config fields across the workspace crates, plus stray config, seed, migration-gap, and test cruft surfaced by the platform audit. No behavior change: every removed code item was dead (an unused export, an `#[allow(dead_code)]`-annotated helper, or a config field read only by a Debug impl). Crates: drop the unused `CurrentUser` extractor; remove the `NowOrDefault` trait (callers use `Clock::now` directly); drop the unused `_user_agent` param on `verify_only`; remove `_enforce_user_id_used` and the unused `UserId` import in signup; delete the never-used `RefreshTokenRow`/`RefreshFamilyRow` rows and their `From` impls; drop the 4 dead `AuthConfig` bool fields and the now-unused `parse_bool` helper; drop the 3 dead `EngineConfig` TTL defaults; remove the superseded `UserRepository::list_by_tenant` and `AuditLogger::list_recent`; drop the unused `_verifying_keys` map; delete the never-constructed `TicketActivity` enum. Stray: remove the dead `ticket.sla_warning`/`ticket.sla_breach` seed templates (no emitters); replace the hardcoded developer LAN IP in the demo script with a `localhost` default; add a `20260506000007_DELETED.md` placeholder documenting the intentional auth-migrations gap (sqlx ignores non-`.sql` files); document multi-tenant-only tenancy in the README now that the `single-tenant` cargo feature is gone (PMS-262); provision an `E2E_FOREIGN_COMPANY_ID` fixture in `global.setup.ts` so the cross-tenant company canary runs unconditionally; remove the spurious same-file `#[allow(dead_code)]` annotations in the contacts and knowledge_base integration tests. #PMS-202

David added 1 commit

2026-06-13 19:42:52 +02:00

chore(cleanup): remove dead crates code and stray config/seed/test cruft

E2E / Playwright against staging (pull_request) Failing after 36s

Details

Check / fmt + clippy + compile + tests (pull_request) Failing after 2m47s

Details

398c0babb7

Remove dead structs, traits, params, and config fields across the workspace crates, plus stray config, seed, migration-gap, and test cruft surfaced by the platform audit. No behavior change: every removed code item was dead (an unused export, an `#[allow(dead_code)]`-annotated helper, or a config field read only by a Debug impl).

Crates: drop the unused `CurrentUser` extractor; remove the `NowOrDefault` trait (callers use `Clock::now` directly); drop the unused `_user_agent` param on `verify_only`; remove `_enforce_user_id_used` and the unused `UserId` import in signup; delete the never-used `RefreshTokenRow`/`RefreshFamilyRow` rows and their `From` impls; drop the 4 dead `AuthConfig` bool fields and the now-unused `parse_bool` helper; drop the 3 dead `EngineConfig` TTL defaults; remove the superseded `UserRepository::list_by_tenant` and `AuditLogger::list_recent`; drop the unused `_verifying_keys` map; delete the never-constructed `TicketActivity` enum.

Stray: remove the dead `ticket.sla_warning`/`ticket.sla_breach` seed templates (no emitters); replace the hardcoded developer LAN IP in the demo script with a `localhost` default; add a `20260506000007_DELETED.md` placeholder documenting the intentional auth-migrations gap (sqlx ignores non-`.sql` files); document multi-tenant-only tenancy in the README now that the `single-tenant` cargo feature is gone (PMS-262); provision an `E2E_FOREIGN_COMPANY_ID` fixture in `global.setup.ts` so the cross-tenant company canary runs unconditionally; remove the spurious same-file `#[allow(dead_code)]` annotations in the contacts and knowledge_base integration tests.

#PMS-202

David added 1 commit

2026-06-14 00:36:46 +02:00

Merge origin/main into chore/pms-202-remove-dead-code

E2E / Playwright against staging (pull_request) Failing after 16s

Details

Check / fmt + clippy + compile + tests (pull_request) Successful in 3m8s

Details

Create release / Create release from merged PR (pull_request) Has been skipped

Details

1f4884eac9