fix(ui): wire theme-token guard into CI and tokenize grays #484
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/MAPPS-401-theme-token-ci"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
check.yml ran the runner-label guard, fmt, clippy, the wasm build, and the unit tests but never scripts/check-theme-tokens.sh, so the MAPPS-259 semantic-token rule was enforced only locally and 17 hardcoded-gray lines drifted back onto main. Add a Theme-token guard step next to the runner-label guard so a new hardcoded neutral fails CI (just check already ran the guard locally).
Migrate the 17 violations onto the input.css tokens, collapsing each light+dark: pair to the single token that carries dark mode through the CSS vars: labels and headings to text-content, secondary/body copy to text-muted, chevrons to text-subtle, card and chip surfaces to bg-surface / bg-surface-2, dividers to border-line, and the global-search icon button onto the top-bar convention (text-subtle hover:text-content hover:bg-surface-2). CollapsibleCard now matches Card's token classes exactly.
The shape sweep for the same invariant turned up one neutral the guard's pattern missed: SearchInput's placeholder-gray-500 / focus:placeholder-gray-400. Tokenize it to placeholder-subtle and extend the guard pattern to cover the placeholder- prefix. calendar.rs's bg-slate-600 fallback is part of the opted-out event-type data-viz palette, and collapsible_rail's bg-black/30 is a modal scrim, not a themed surface.
#MAPPS-401