fix(ui): hover feedback on clickable rows and Secondary button #477

Merged

nrupard merged 1 commit from fix/MAPPS-411-hover-feedback into main

2026-08-05 18:20:42 +02:00

nrupard commented

2026-08-05 18:18:25 +02:00

Owner

Implements MAPPS-411 (2026-08-04 mokosh-apps UI audit, F15/F19/F20): clickable rows and the Secondary button now give hover feedback. 3 files.

F19 - QuoteRow highlights on hover

QuoteRow set a manual class: "cursor-pointer" with an onclick, so it navigated and showed a pointer but never highlighted, unlike the other 25 clickable rows. It now uses TableRow { clickable: true }, which yields the shared hover:bg-surface-2 cursor-pointer transition-colors. The manual cursor class is dropped.

F20 - projects task row hover is visible

The project-detail task row set bg-surface-2 ... hover:bg-surface-2, so hovering an already-bg-surface-2 element changed the cursor but not the background (dead hover). The resting background is now bg-surface, so hover:bg-surface-2 produces a visible change.

F15 - Secondary button hover + focus ring

ButtonVariant::Secondary was the only variant with no hover feedback and no mouse-focus ring color (the shared base sets focus:ring-2 focus:ring-offset-2 but the variant supplied no ring color). It now appends hover:opacity-90 focus:ring-line-strong, matching the sibling variants and the existing .btn-secondary definition in input.css (line-strong is a defined theme token).

Completeness sweep

F19: QuoteRow was the only clickable TableRow using a manual cursor class; the other cursor-pointer elements are buttons/cards/calendar cells with their own hover, not table rows.
F20: the project task row was the only element whose resting and hover background were the same token; the table pagination buttons (bg-surface -> hover:bg-surface-2) already differ.
F15: Secondary has a single definition.

Verification

Diff-reviewed (no local cargo): line-strong resolves as a theme token, the base class carries focus:ring-2, no em-dash. CI runs fmt/clippy(-D warnings)/wasm-build/tests.

#MAPPS-411

Implements MAPPS-411 (2026-08-04 mokosh-apps UI audit, F15/F19/F20): clickable rows and the Secondary button now give hover feedback. 3 files. ## F19 - QuoteRow highlights on hover `QuoteRow` set a manual `class: "cursor-pointer"` with an onclick, so it navigated and showed a pointer but never highlighted, unlike the other 25 clickable rows. It now uses `TableRow { clickable: true }`, which yields the shared `hover:bg-surface-2 cursor-pointer transition-colors`. The manual cursor class is dropped. ## F20 - projects task row hover is visible The project-detail task row set `bg-surface-2 ... hover:bg-surface-2`, so hovering an already-`bg-surface-2` element changed the cursor but not the background (dead hover). The resting background is now `bg-surface`, so `hover:bg-surface-2` produces a visible change. ## F15 - Secondary button hover + focus ring `ButtonVariant::Secondary` was the only variant with no hover feedback and no mouse-focus ring color (the shared base sets `focus:ring-2 focus:ring-offset-2` but the variant supplied no ring color). It now appends `hover:opacity-90 focus:ring-line-strong`, matching the sibling variants and the existing `.btn-secondary` definition in input.css (`line-strong` is a defined theme token). ## Completeness sweep - F19: `QuoteRow` was the only clickable `TableRow` using a manual cursor class; the other cursor-pointer elements are buttons/cards/calendar cells with their own hover, not table rows. - F20: the project task row was the only element whose resting and hover background were the same token; the table pagination buttons (`bg-surface` -> `hover:bg-surface-2`) already differ. - F15: `Secondary` has a single definition. ## Verification Diff-reviewed (no local cargo): `line-strong` resolves as a theme token, the base class carries `focus:ring-2`, no em-dash. CI runs fmt/clippy(-D warnings)/wasm-build/tests. #MAPPS-411

nrupard added 1 commit

2026-08-05 18:18:25 +02:00

fix(ui): hover feedback on clickable rows and Secondary button

Check / fmt + clippy + tests (pull_request) Successful in 2m13s

Details

Create release / Create release from merged PR (pull_request) Has been skipped

Details

6eb6589de3

Implements MAPPS-411 (2026-08-04 UI audit F15/F19/F20). QuoteRow uses TableRow { clickable: true } instead of a manual cursor class, so it highlights on hover like every other clickable row; the project task row's resting background changes from bg-surface-2 to bg-surface so its hover:bg-surface-2 is visible; and the Secondary button variant appends hover:opacity-90 focus:ring-line-strong, matching the sibling variants and the existing .btn-secondary definition.

#MAPPS-411

nrupard scheduled this pull request to auto merge when all checks succeed

2026-08-05 18:19:09 +02:00