fix(portal): replace hardcoded demo rows with honest empty states #472

Merged

nrupard merged 2 commits from fix/MAPPS-414-portal-list-demo into main

2026-08-05 15:41:33 +02:00

nrupard commented

2026-08-04 21:51:47 +02:00

Owner

Removes the hardcoded demo rows that PortalTicketListPage and PortalInvoiceListPage shipped to real signed-in clients (TKT-/INV- numbers, fabricated $2,500.00 amounts, decorative "View"/"Pay Now" buttons). This is the same fabricated-data-to-clients defect MAPPS-403 fixed on PortalHomePage, on two surfaces the 2026-08-04 UI audit's F17 did not cover.

Changes

PortalTicketListPage: the three static demo tickets are replaced with an honest "No tickets yet." empty state in a Card, matching the merged MAPPS-403 placeholder style. The header and "New Ticket" nav button are unchanged.
PortalInvoiceListPage: the three demo invoice rows (fabricated amounts + decorative buttons) are replaced with "No invoices yet."
Removes the now-unused PortalTicketRow component and its props, and drops the orphaned ticket_status_badge import (still used by tickets.rs / dashboard.rs via their own imports).
Each page carries a comment noting the eventual fix: wire the portal ticket-list / invoice-list endpoints via use_resource + get_portal_authed + use_server_reachable, mirroring PortalInvoiceDetailPage (feature-gate now, wire later).

Verification

Diff-reviewed (no local cargo on this box): no TKT-/INV-/$-amount literals remain in either page, and no import is orphaned by the deletions (every kept table/badge/button symbol still has a usage in portal.rs). CI runs fmt/clippy/wasm-build/tests.

#MAPPS-414

Removes the hardcoded demo rows that `PortalTicketListPage` and `PortalInvoiceListPage` shipped to real signed-in clients (TKT-/INV- numbers, fabricated `$2,500.00` amounts, decorative "View"/"Pay Now" buttons). This is the same fabricated-data-to-clients defect MAPPS-403 fixed on `PortalHomePage`, on two surfaces the 2026-08-04 UI audit's F17 did not cover. ## Changes - `PortalTicketListPage`: the three static demo tickets are replaced with an honest "No tickets yet." empty state in a `Card`, matching the merged MAPPS-403 placeholder style. The header and "New Ticket" nav button are unchanged. - `PortalInvoiceListPage`: the three demo invoice rows (fabricated amounts + decorative buttons) are replaced with "No invoices yet." - Removes the now-unused `PortalTicketRow` component and its props, and drops the orphaned `ticket_status_badge` import (still used by tickets.rs / dashboard.rs via their own imports). - Each page carries a comment noting the eventual fix: wire the portal ticket-list / invoice-list endpoints via `use_resource` + `get_portal_authed` + `use_server_reachable`, mirroring `PortalInvoiceDetailPage` (feature-gate now, wire later). ## Verification Diff-reviewed (no local cargo on this box): no `TKT-`/`INV-`/`$`-amount literals remain in either page, and no import is orphaned by the deletions (every kept table/badge/button symbol still has a usage in portal.rs). CI runs fmt/clippy/wasm-build/tests. #MAPPS-414

nrupard added 1 commit

2026-08-04 21:51:48 +02:00

fix(portal): replace hardcoded demo rows with honest empty states

Check / fmt + clippy + tests (pull_request) Failing after 10s

Details

1c0ef6227c

PortalTicketListPage and PortalInvoiceListPage shipped hardcoded demo rows (TKT-/INV- numbers, fabricated $2,500.00 amounts, decorative buttons) to real signed-in clients, the same fabricated-data defect MAPPS-403 fixed on PortalHomePage. Both pages now render an honest "No tickets yet." / "No invoices yet." placeholder until the portal ticket-list and invoice-list endpoints are wired via use_resource + get_portal_authed + use_server_reachable (mirroring PortalInvoiceDetailPage). Removes the now-unused PortalTicketRow helper and the orphaned ticket_status_badge import.

#MAPPS-414

nrupard scheduled this pull request to auto merge when all checks succeed

2026-08-05 15:27:16 +02:00

nrupard added 1 commit

2026-08-05 15:40:10 +02:00

style(portal): rustfmt import wrapping

Check / fmt + clippy + tests (pull_request) Successful in 1m21s

Details

Create release / Create release from merged PR (pull_request) Has been skipped

Details

b22f13b916

Reflow the components import to rustfmt's canonical wrap; the hand-edited block in the prior commit put CurrencyIcon on the wrong line and failed cargo fmt --check in CI.

#MAPPS-414