psa-systems/mokosh-apps
Watch
9
0
Fork
You've already forked mokosh-apps
 0
Code Issues Pull requests 1 Projects Releases 14 Packages Wiki Activity Actions

fix(ui): stop the portal rendering its page title twice #468

Merged
nrupard merged 1 commit from fix/MAPPS-402-portal-title-twice into main 2026-08-04 20:16:56 +02:00
Conversation 0 Commits 1 Files changed 1 +4 -4
nrupard commented 2026-08-04 20:13:29 +02:00
Owner
Copy link

What

Drop the redundant PortalLayout title: prop on the Home, Invoice-detail, and Quotes-list pages (each already renders its own heading), and set the Quotes h1 to font-bold.

Why

Those three rendered an identical/redundant heading twice (the layout title h1 stacked above the page own h1). UI audit (MAPPS-399) finding F7, a regression of MAPPS-94. title is #[props(default)] so dropping it is the same call the TicketList/InvoiceList/KB pages already make.

Ticket-detail and quote-detail are intentionally left: their layout title (record ID) is distinct from their card heading (subject/number), so those are a title + content-heading, folded into MAPPS-408.

Closes MAPPS-402.

## What Drop the redundant PortalLayout `title:` prop on the Home, Invoice-detail, and Quotes-list pages (each already renders its own heading), and set the Quotes h1 to `font-bold`. ## Why Those three rendered an identical/redundant heading twice (the layout `title` h1 stacked above the page own h1). UI audit (MAPPS-399) finding F7, a regression of MAPPS-94. `title` is `#[props(default)]` so dropping it is the same call the TicketList/InvoiceList/KB pages already make. Ticket-detail and quote-detail are intentionally left: their layout title (record ID) is distinct from their card heading (subject/number), so those are a title + content-heading, folded into MAPPS-408. Closes MAPPS-402.
fix(ui): stop the portal rendering its page title twice
All checks were successful
Check / fmt + clippy + tests (pull_request) Successful in 1m24s
Details
Create release / Create release from merged PR (pull_request) Has been skipped
Details
db9be92aaf 
PortalLayout renders an h1 from its optional `title` prop into the same main column as its page children, so passing it stacks a second heading. Three portal pages rendered a redundant/identical heading twice: Home ("Home" above the "Welcome back" greeting), Invoice detail ("Invoice N" as the layout title AND the card masthead), and the Quotes list ("Quotes" twice, at mismatched weights). Drop the `title:` prop on those three (each keeps its own heading, matching the TicketList / InvoiceList / KB pages that already pass no title), and align the Quotes h1 to font-bold.

The ticket-detail (430) and quote-detail (1307) pages are left as-is: their layout title is the record ID ("Ticket N" / "Quote") and their card heading is the distinct subject / number, so those are a title + content-heading, not a redundant double. Their h1 hierarchy is folded into MAPPS-408. Found by the 2026-08-04 UI audit (MAPPS-399), finding F7; regression of MAPPS-94.

#MAPPS-402

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
nrupard deleted branch fix/MAPPS-402-portal-title-twice 2026-08-04 20:16:57 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/mokosh-apps!468
No description provided.