fix(oci): pre-stage wasm-opt where dx 0.7.7 looks for it #456

Merged

Claude-Run merged 1 commit from fix/MAPPS-381-wasm-opt-prestage-path into main

2026-08-01 00:38:42 +02:00

Claude-Run commented

2026-08-01 00:34:38 +02:00

Member

dx 0.7.7 moved its wasm-opt lookup from <DX_HOME>/binaryen/bin/wasm-opt to <DX_HOME>/tools/binaryen-<BINARYEN_VERSION>/bin/wasm-opt, so the pre-staged symlink stopped short-circuiting the install and every build fell back to downloading binaryen from GitHub. In run #1801 that download unpacked nothing (dx's install_github ignores tar errors, so a bad download still logs "wasm-opt installed from Github"), dx then exec'd a path that did not exist and the build died with "Failed to run wasm-opt: No such file or directory (os error 2)".

Park the Debian-packaged wasm-opt at the path dx 0.7.7 actually checks, and assert in the same layer with dx doctor that dx sees it. The assertion turns a future dx path change into an immediate named failure at a cheap layer instead of a silent regression back to the flaky GitHub download.

#MAPPS-381

Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com

dx 0.7.7 moved its wasm-opt lookup from `<DX_HOME>/binaryen/bin/wasm-opt` to `<DX_HOME>/tools/binaryen-<BINARYEN_VERSION>/bin/wasm-opt`, so the pre-staged symlink stopped short-circuiting the install and every build fell back to downloading binaryen from GitHub. In run #1801 that download unpacked nothing (dx's install_github ignores tar errors, so a bad download still logs "wasm-opt installed from Github"), dx then exec'd a path that did not exist and the build died with "Failed to run wasm-opt: No such file or directory (os error 2)". Park the Debian-packaged wasm-opt at the path dx 0.7.7 actually checks, and assert in the same layer with `dx doctor` that dx sees it. The assertion turns a future dx path change into an immediate named failure at a cheap layer instead of a silent regression back to the flaky GitHub download. #MAPPS-381 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Claude-Run added 1 commit

2026-08-01 00:34:38 +02:00

fix(oci): pre-stage wasm-opt where dx 0.7.7 looks for it

Check / fmt + clippy + tests (pull_request) Successful in 3m22s

Details

Create release / Create release from merged PR (pull_request) Has been skipped

Details

1919c2a50a

dx 0.7.7 moved its wasm-opt lookup from `<DX_HOME>/binaryen/bin/wasm-opt` to `<DX_HOME>/tools/binaryen-<BINARYEN_VERSION>/bin/wasm-opt`, so the pre-staged symlink stopped short-circuiting the install and every build fell back to downloading binaryen from GitHub. In run #1801 that download unpacked nothing (dx's install_github ignores tar errors, so a bad download still logs "wasm-opt installed from Github"), dx then exec'd a path that did not exist and the build died with "Failed to run wasm-opt: No such file or directory (os error 2)".

Park the Debian-packaged wasm-opt at the path dx 0.7.7 actually checks, and assert in the same layer with `dx doctor` that dx sees it. The assertion turns a future dx path change into an immediate named failure at a cheap layer instead of a silent regression back to the flaky GitHub download.

#MAPPS-381

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>