psa-systems/mokosh-apps
Watch
9
0
Fork
You've already forked mokosh-apps
 0
Code Issues Pull requests 1 Projects Releases 14 Packages Wiki Activity Actions

fix(portal): route portal invoice amounts through format_money_str (MAPPS-272) #286

Merged
YousifShkara merged 1 commit from fix/MAPPS-272-currency-format into main 2026-06-21 07:13:42 +02:00
Conversation 0 Commits 1 Files changed 1 +7 -6
YousifShkara commented 2026-06-21 07:05:01 +02:00
Owner
Copy link

portal_money short-circuited the shared format_money_str helper and just prepended $ to the raw server-serialized decimal string. A payload of "60000.00" rendered as $60000.00 (no thousands separator) while the rest of the app uses $60,000.00. Route through the existing money helper so every surface formats currency identically. The other currency renders the QA report flagged (Projects "Total Budget" / "Remaining") already go through format_money_f64; the portal helper was the last bypass.

#MAPPS-272

`portal_money` short-circuited the shared `format_money_str` helper and just prepended `$` to the raw server-serialized decimal string. A payload of `"60000.00"` rendered as `$60000.00` (no thousands separator) while the rest of the app uses `$60,000.00`. Route through the existing money helper so every surface formats currency identically. The other currency renders the QA report flagged (Projects "Total Budget" / "Remaining") already go through `format_money_f64`; the portal helper was the last bypass. #MAPPS-272
fix(portal): route portal invoice amounts through format_money_str (MAPPS-272)
All checks were successful
Check / clippy + fmt + tests (pull_request) Successful in 1m18s
Details
Create release / Create release from merged PR (pull_request) Has been skipped
Details
979afbb0c1 
`portal_money` short-circuited the shared `format_money_str` helper and just prepended `$` to the raw server-serialized decimal string. A payload of `"60000.00"` rendered as `$60000.00` (no thousands separator) while the rest of the app uses `$60,000.00`. Route through the existing money helper so every surface formats currency identically. The other currency renders the QA report flagged (Projects "Total Budget" / "Remaining") already go through `format_money_f64`; the portal helper was the last bypass.

#MAPPS-272
YousifShkara deleted branch fix/MAPPS-272-currency-format 2026-06-21 07:13:43 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
YousifShkara
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/mokosh-apps!286
No description provided.