refactor(badges): centralize status->BadgeVariant mapping per domain

David commented

2026-06-17 22:56:11 +02:00

Owner

Every page hand-rolled its own status_variant() / *_status_badge() copy (contract, asset, project, invoice, KB article, ticket) and the copies drifted: the portal invoice mapper knew overdue and defaulted to Yellow while billing's defaulted to Gray and never handled overdue; the contract mapper was duplicated verbatim across contracts.rs and contacts.rs. New server statuses fell back to silent Gray inconsistently per page.

Introduce src/components/status_badge.rs as the single source per domain. Each helper returns (variant, humanized label) so both color and label live in one place; ticket_status_badge moves here unchanged (callers render the status verbatim). Pages now call the shared mappers and the duplicated humanize_*/status_variant/status_badge copies are deleted.

Add BadgeVariant::Orange so an overdue invoice reads distinctly from a written-off/void one (Red), satisfying the expand-coverage goal. Unknown statuses hit an explicit Gray fallback whose label is title-cased from the raw snake_case token rather than leaking partially_refunded. Derive Debug on BadgeVariant for the new unit tests.

#MAPPS-268

Every page hand-rolled its own status_variant() / *_status_badge() copy (contract, asset, project, invoice, KB article, ticket) and the copies drifted: the portal invoice mapper knew `overdue` and defaulted to Yellow while billing's defaulted to Gray and never handled `overdue`; the contract mapper was duplicated verbatim across contracts.rs and contacts.rs. New server statuses fell back to silent Gray inconsistently per page. Introduce src/components/status_badge.rs as the single source per domain. Each helper returns (variant, humanized label) so both color and label live in one place; ticket_status_badge moves here unchanged (callers render the status verbatim). Pages now call the shared mappers and the duplicated humanize_*/status_variant/status_badge copies are deleted. Add BadgeVariant::Orange so an overdue invoice reads distinctly from a written-off/void one (Red), satisfying the expand-coverage goal. Unknown statuses hit an explicit Gray fallback whose label is title-cased from the raw snake_case token rather than leaking `partially_refunded`. Derive Debug on BadgeVariant for the new unit tests. #MAPPS-268

David added 1 commit

2026-06-17 22:56:11 +02:00

refactor(badges): centralize status->BadgeVariant mapping per domain

Check / clippy + fmt + tests (pull_request) Successful in 2m29s

Details

5baf6991f0

Every page hand-rolled its own status_variant() / *_status_badge() copy (contract, asset, project, invoice, KB article, ticket) and the copies drifted: the portal invoice mapper knew `overdue` and defaulted to Yellow while billing's defaulted to Gray and never handled `overdue`; the contract mapper was duplicated verbatim across contracts.rs and contacts.rs. New server statuses fell back to silent Gray inconsistently per page.

Introduce src/components/status_badge.rs as the single source per domain. Each helper returns (variant, humanized label) so both color and label live in one place; ticket_status_badge moves here unchanged (callers render the status verbatim). Pages now call the shared mappers and the duplicated humanize_*/status_variant/status_badge copies are deleted.

Add BadgeVariant::Orange so an overdue invoice reads distinctly from a written-off/void one (Red), satisfying the expand-coverage goal. Unknown statuses hit an explicit Gray fallback whose label is title-cased from the raw snake_case token rather than leaking `partially_refunded`. Derive Debug on BadgeVariant for the new unit tests.

#MAPPS-268

vas2000-work force-pushed refactor/MAPPS-268-centralize-status-badges from 5baf6991f0

Check / clippy + fmt + tests (pull_request) Successful in 2m29s

Details

to a0b4a3a6ae

Check / clippy + fmt + tests (pull_request) Successful in 1m52s

Details

Create release / Create release from merged PR (pull_request) Has been skipped

Details

2026-06-17 23:58:48 +02:00

Compare