fix(reports): drop 'charts coming soon' placeholder from report views #226

Merged

nrupard merged 1 commit from fix/PMS-356-remove-revenue-chart-placeholder into main

2026-06-16 17:15:44 +02:00

nrupard commented

2026-06-16 17:13:39 +02:00

Owner

What

Removes the "Charts coming soon / Time-series charts are coming soon" placeholder that shipped to production on the Reports pages (PMS-356, external review finding #7).

The Trend card was rendered on every supported report view (ticket, time, billing, project, client) next to live Summary and breakdown data, so the "coming soon" copy read as a half-built page. ReportView carries no time-series data (only summary and breakdown key/value pairs), so there was nothing to chart today.

Change

Remove the Trend card and the now-unused ChartComingSoon component from src/pages/reports.rs.
Promote the Summary card to full width with a responsive 2/3/4-column stat grid so it no longer sits in a half-empty two-column layout.
Live Summary and breakdown figures are unchanged. When real time-series data and a chart land, the Trend card returns as a complete feature.

Placeholder audit (AC #2)

Grepped the SPA source for customer-facing "coming soon" / "not yet implemented" copy:

reports.rs Trend card + ChartComingSoon - fixed here.
reports.rs custom-report-builder branch ("This report isn't available yet ... planned but not implemented") - left as-is: it is an honest unavailable-state message for a genuinely absent report, not a half-built feature shipped as if done. Tracked separately if product wants it removed from nav.
portal.rs "Coming soon" empty state on the client portal - separate customer surface; out of scope for this PR, flagged for its own triage.

CI grep gate (AC #3)

Not added here. A naive grep would flag the many benign placeholder: input attributes and code comments; a useful gate must scope to rendered display strings only. Recommend a follow-up if product wants the preventive check.

Verification

cargo fmt --all
cargo clippy --target wasm32-unknown-unknown -- -D warnings clean
Compiles to wasm32-unknown-unknown

🤖 Generated with Claude Code

## What Removes the "Charts coming soon / Time-series charts are coming soon" placeholder that shipped to production on the Reports pages (PMS-356, external review finding #7). The Trend card was rendered on every supported report view (ticket, time, billing, project, client) next to live Summary and breakdown data, so the "coming soon" copy read as a half-built page. `ReportView` carries no time-series data (only `summary` and `breakdown` key/value pairs), so there was nothing to chart today. ## Change - Remove the Trend card and the now-unused `ChartComingSoon` component from `src/pages/reports.rs`. - Promote the Summary card to full width with a responsive 2/3/4-column stat grid so it no longer sits in a half-empty two-column layout. - Live Summary and breakdown figures are unchanged. When real time-series data and a chart land, the Trend card returns as a complete feature. ## Placeholder audit (AC #2) Grepped the SPA source for customer-facing "coming soon" / "not yet implemented" copy: - `reports.rs` Trend card + `ChartComingSoon` - fixed here. - `reports.rs` custom-report-builder branch ("This report isn't available yet ... planned but not implemented") - left as-is: it is an honest unavailable-state message for a genuinely absent report, not a half-built feature shipped as if done. Tracked separately if product wants it removed from nav. - `portal.rs` "Coming soon" empty state on the client portal - separate customer surface; out of scope for this PR, flagged for its own triage. ## CI grep gate (AC #3) Not added here. A naive grep would flag the many benign `placeholder:` input attributes and code comments; a useful gate must scope to rendered display strings only. Recommend a follow-up if product wants the preventive check. ## Verification - `cargo fmt --all` - `cargo clippy --target wasm32-unknown-unknown -- -D warnings` clean - Compiles to wasm32-unknown-unknown 🤖 Generated with [Claude Code](https://claude.com/claude-code)

nrupard added 1 commit

2026-06-16 17:13:39 +02:00

fix(reports): drop "charts coming soon" placeholder from report views

Check / clippy + fmt + tests (pull_request) Successful in 1m7s

Details

Create release / Create release from merged PR (pull_request) Has been skipped

Details

ae6c754342

The Trend card on every supported report (ticket/time/billing/project/client) rendered a "Charts coming soon / Time-series charts are coming soon" placeholder shipped to production, which reads as half-built next to the live Summary and breakdown data. The ReportView model carries no time-series data (only summary and breakdown key/value pairs), so there is nothing to chart today.

Remove the Trend card and the now-unused ChartComingSoon component entirely. The Summary card goes full-width with a responsive 2/3/4-column stat grid so it no longer sits in a half-empty two-column layout. Live Summary and breakdown figures are unchanged. When real time-series data and a chart land, the Trend card returns as a complete feature rather than a placeholder.

#PMS-356

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>