psa-systems/mokosh-apps
Watch
9
0
Fork
You've already forked mokosh-apps
 0
Code Issues Pull requests 1 Projects Releases 14 Packages Wiki Activity Actions

fix(settings): make SettingFormModal own its title and label strings #149

Closed
David wants to merge 0 commits from chore/checks-workflow-80f008f1 into main
pull from: chore/checks-workflow-80f008f1
merge into: psa-systems:main
Conversation 0 Commits - Files changed 223 +5 -5
David commented 2026-06-15 15:51:08 +02:00
Owner
Copy link

The check.yml workflow failed to compile src/pages/settings.rs. The
SettingFormModal props typed title and create_label as &'static str,
but the rsx call sites pass the title through an if/else that the rsx
macro materializes into an owned String, yielding "expected &str, found
String". Every other component in the crate types these props as String,
so this aligns the modal with that convention and lets the call sites pass
both literals and conditionals unchanged.

Also fix an E0597 in use_is_admin: the auth.read() guard was the block's
tail expression, so its temporary outlived the auth binding it borrows.
Binding the guard to a named local drops it before auth, leaving the tail
expression a plain bool.

#MAPPS-171

The check.yml workflow failed to compile src/pages/settings.rs. The SettingFormModal props typed `title` and `create_label` as `&'static str`, but the rsx call sites pass the `title` through an `if/else` that the rsx macro materializes into an owned `String`, yielding "expected `&str`, found `String`". Every other component in the crate types these props as `String`, so this aligns the modal with that convention and lets the call sites pass both literals and conditionals unchanged. Also fix an E0597 in `use_is_admin`: the `auth.read()` guard was the block's tail expression, so its temporary outlived the `auth` binding it borrows. Binding the guard to a named local drops it before `auth`, leaving the tail expression a plain `bool`. #MAPPS-171
fix(settings): make SettingFormModal own its title and label strings
All checks were successful
Check / clippy + fmt + tests (pull_request) Successful in 50s
Details
Create release / Create release from merged PR (pull_request) Has been skipped
Details
7f063f6ade 
The check.yml workflow failed to compile src/pages/settings.rs. The
SettingFormModal props typed `title` and `create_label` as `&'static str`,
but the rsx call sites pass the `title` through an `if/else` that the rsx
macro materializes into an owned `String`, yielding "expected `&str`, found
`String`". Every other component in the crate types these props as `String`,
so this aligns the modal with that convention and lets the call sites pass
both literals and conditionals unchanged.

Also fix an E0597 in `use_is_admin`: the `auth.read()` guard was the block's
tail expression, so its temporary outlived the `auth` binding it borrows.
Binding the guard to a named local drops it before `auth`, leaving the tail
expression a plain `bool`.

#MAPPS-171
nrupard closed this pull request 2026-06-15 15:52:16 +02:00
All checks were successful
Check / clippy + fmt + tests (pull_request) Successful in 50s
Required
Details
Create release / Create release from merged PR (pull_request) Has been skipped
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/mokosh-apps!149
No description provided.