fix(contacts): fetch the requested page on pagination change #134

Merged

David merged 1 commit from fix/mapps-148-pagination-fetch-next-page into main

2026-06-14 15:56:10 +02:00

David commented

2026-06-14 15:28:33 +02:00

Owner

The Companies and Contacts list views computed page/filter/sort snapshots in the component body and captured them by value into the use_resource closure. Dioxus use_resource only restarts when a signal read inside the closure changes, so the resource never subscribed to the page signal: clicking a page number advanced the "Showing X to Y" footer (rendered from the current_page prop) but fired no request, leaving the stale page-1 rows on screen.

Read the page, search, filter, and sort signals inside the resource closure so the resource subscribes to them and re-fetches the requested page, binding the returned rows. active_tenant_generation is still read so an org switch / token swap continues to re-fetch.

#MAPPS-148

The Companies and Contacts list views computed page/filter/sort snapshots in the component body and captured them by value into the `use_resource` closure. Dioxus `use_resource` only restarts when a signal read inside the closure changes, so the resource never subscribed to the `page` signal: clicking a page number advanced the "Showing X to Y" footer (rendered from the `current_page` prop) but fired no request, leaving the stale page-1 rows on screen. Read the `page`, search, filter, and sort signals inside the resource closure so the resource subscribes to them and re-fetches the requested page, binding the returned rows. `active_tenant_generation` is still read so an org switch / token swap continues to re-fetch. #MAPPS-148

David added 1 commit

2026-06-14 15:28:33 +02:00

fix(contacts): fetch the requested page on pagination change

Check / clippy + fmt + tests (pull_request) Successful in 50s

Details

Create release / Create release from merged PR (pull_request) Has been skipped

Details

7162edbbe8

The Companies and Contacts list views computed page/filter/sort snapshots in the component body and captured them by value into the `use_resource` closure. Dioxus `use_resource` only restarts when a signal read inside the closure changes, so the resource never subscribed to the `page` signal: clicking a page number advanced the "Showing X to Y" footer (rendered from the `current_page` prop) but fired no request, leaving the stale page-1 rows on screen.

Read the `page`, search, filter, and sort signals inside the resource closure so the resource subscribes to them and re-fetches the requested page, binding the returned rows. `active_tenant_generation` is still read so an org switch / token swap continues to re-fetch.

#MAPPS-148