fix/listener-accumulation #69

Merged

longjacksonle merged 11 commits from fix/listener-accumulation into main

2026-05-11 17:08:45 +02:00

longjacksonle commented

2026-05-11 17:08:37 +02:00

Owner

No description provided.

longjacksonle added 11 commits

2026-05-11 17:08:37 +02:00

docs(superpowers): add phase 20 plan for listener accumulation fix 78779e3f7c

docs(superpowers): expand phase 20 smoke test and rationale detail fc45ea2785

fix(ws): tear down body event listeners on HTMX cleanup to prevent accumulation across soft-refreshes 9ca0dacec5

Without explicit removal, every WS reconnect soft-refresh would register additional `htmx:wsOpen`, `htmx:beforeSwap`, `htmx:afterSwap`, `htmx:oobBeforeSwap`, and `htmx:oobAfterSwap` listeners on `document.body`. After N reconnects the subscribe frame would fire N times and scroll logic would run N times per swap.

Named functions replace the anonymous callbacks so they can be passed to `removeEventListener`. A `htmx:beforeCleanupElement` listener (with `{ once: true }`) on the nearest cleanup root tears everything down when HTMX replaces the enclosing fragment.

fix(composer): tear down htmx:afterSwap body listener on HTMX cleanup c28db9e66b

fix(notify): tear down document click listener on HTMX cleanup to prevent accumulation ad49914e65

fix(ws): tear down wsOpen listener on room page cleanup to prevent accumulation 3f7226997f

Without teardown, every soft-refresh (reconnect) adds another htmx:wsOpen listener on document.body, causing the subscribe frame to fire N times per reconnect. Wraps the handler in an IIFE and removes it via htmx:beforeCleanupElement, matching the pattern used in the composer and notify fixes.

docs(layout): clarify persistent-shell script lifetime to explain no teardown needed db0a013905

docs(layout): add comment explaining persistent-shell script lifetime rationale 07aa8b1ae9

fix(blocked): tear down document click listener and debounce timer on HTMX cleanup d2b6afb40c

docs(CLAUDE.md): document inline script teardown pattern and persistent-shell exception 8c968ecb1c

chore: allow echo exit-code command in settings and tidy test assertion

Check / clippy + fmt + tests (pull_request) Failing after 28s

Details

ae5911be59