Fix: replace nonexistent `server` feature flag in check.yml #65

Merged

David merged 1 commit from fix/check-yml-features-flag into main

2026-05-10 23:44:50 +02:00

David commented

2026-05-10 23:40:37 +02:00

Owner

Summary

check.yml references --features server, which does not exist anywhere in this workspace. The actual cargo features are standalone (default on lets-chat-server) and saas; the resolver would have always failed on the existing steps. Also drops a cargo check --target wasm32-unknown-unknown step since neither workspace member targets WASM (server is Axum, desktop is Tao+Wry).

Changes

clippy --features server --no-default-features --all-targets -> two steps: clippy --all-targets (workspace, default-features-on = standalone) and clippy -p lets-chat-server --no-default-features --features saas for the saas mode.
cargo check --features server and cargo check --target wasm32-unknown-unknown removed; the build steps below already exercise compilation.
cargo build --features server --no-default-features --all-targets -> cargo build --all-targets (workspace, standalone) plus cargo build -p lets-chat-server --no-default-features --features saas.
cargo test --lib --features server --no-default-features -> cargo test --lib -p lets-chat-server.

Mirrors the local just check + just test recipes (which use ./dev/cargo) step-for-step, just translated to the CI runner where cargo is on PATH directly.

Test plan

CI run on the branch passes.
just check and just test still pass locally (no recipe changes).

## Summary `check.yml` references `--features server`, which does not exist anywhere in this workspace. The actual cargo features are `standalone` (default on `lets-chat-server`) and `saas`; the resolver would have always failed on the existing steps. Also drops a `cargo check --target wasm32-unknown-unknown` step since neither workspace member targets WASM (server is Axum, desktop is Tao+Wry). ## Changes - `clippy --features server --no-default-features --all-targets` -> two steps: `clippy --all-targets` (workspace, default-features-on = standalone) and `clippy -p lets-chat-server --no-default-features --features saas` for the saas mode. - `cargo check --features server` and `cargo check --target wasm32-unknown-unknown` removed; the build steps below already exercise compilation. - `cargo build --features server --no-default-features --all-targets` -> `cargo build --all-targets` (workspace, standalone) plus `cargo build -p lets-chat-server --no-default-features --features saas`. - `cargo test --lib --features server --no-default-features` -> `cargo test --lib -p lets-chat-server`. Mirrors the local `just check` + `just test` recipes (which use `./dev/cargo`) step-for-step, just translated to the CI runner where cargo is on PATH directly. ## Test plan - [ ] CI run on the branch passes. - [ ] `just check` and `just test` still pass locally (no recipe changes).

David added 1 commit

2026-05-10 23:40:38 +02:00

fix: replace nonexistent server feature flag in check.yml

Check / clippy + fmt + tests (pull_request) Failing after 13s

Details

0a7a3fba04

The workspace's actual cargo features are `standalone` (default on the `lets-chat-server` crate) and `saas`; there is no `server` feature anywhere, and `cargo check --features server --no-default-features` would always fail at the resolver. Also drops the `cargo check --target wasm32-unknown-unknown` step because nothing in this workspace targets WASM (server is Axum, desktop is Tao+Wry).

The new check.yml mirrors the local `just check` + `just test` recipes step-for-step: workspace clippy and build cover both server (standalone) and desktop; a saas variant runs clippy + build against `-p lets-chat-server --no-default-features --features saas`; tests run on the server crate in standalone mode.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>