fix(reactions): make the picker filter actually hide cells (LC-391) #403
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/lc-389-full-emoji-picker"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The LC-274 filter hides non-matching cells via the [hidden] attribute, but .lc-emoji-cell (display:inline-flex) and .lc-emoji-tabs (display:flex) are author rules that override the UA [hidden]{display:none} regardless of specificity, so filtered-out cells and the hidden tab strip kept showing and the filter looked dead (typing "heart" narrowed nothing). Same class of bug as the LC-385 regression.
Add .lc-emoji-cell[hidden], .lc-emoji-tabs[hidden] { display: none } - the attribute-qualified selector (0,2,0) beats the bare class (0,1,0), no !important needed. Category sections already hide (default block display), so a matching category now shows only its matching cells. Fixes both the reaction and composer pickers in all four themes.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com
The LC-274 filter hides non-matching cells via the [hidden] attribute, but .lc-emoji-cell (display:inline-flex) and .lc-emoji-tabs (display:flex) are author rules that override the UA [hidden]{display:none} regardless of specificity, so filtered-out cells and the hidden tab strip kept showing and the filter looked dead (typing "heart" narrowed nothing). Same class of bug as the LC-385 regression. Add .lc-emoji-cell[hidden], .lc-emoji-tabs[hidden] { display: none } - the attribute-qualified selector (0,2,0) beats the bare class (0,1,0), no !important needed. Category sections already hide (default block display), so a matching category now shows only its matching cells. Fixes both the reaction and composer pickers in all four themes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>