fix(ci): derive desktop publish version from trigger to kill twin-publish race #391

Merged

David merged 2 commits from fix/desktop-twin-trigger-publish into main 2026-06-22 03:02:30 +02:00

Conversation 0 Commits 2 Files changed 2 +48 -12

David commented 2026-06-19 22:06:58 +02:00

Owner

Copy link

Rolls out the GOV-13 twin-trigger publish fix to this repo's desktop-bundle workflows (build-desktop-linux.yml, build-desktop-windows.yml). Part of GOV-16.

Problem

Both workflows resolved the Generic Packages path label (version) from git describe. A release commit is simultaneously a push to main and the tagged commit, so the main-push run and the tag/release run resolved the same vX.Y.Z path and raced to DELETE-then-PUT the same immutable generic-package file: 409 package file already exists. A describe-derived label also published main builds that were N commits past a tag under the bare tag, freezing the latest train and clobbering the release artifact.

Fix

Resolve the path label from the trigger (github.event_name / github.ref), never from git describe: a release/tag build publishes under its semver tag; every other build is a push: branches: main build and publishes under the moving latest package. The two trains write disjoint paths, so they never collide. This matches the proven yotun desktop pattern and the forgejo-cli reference adopted in GOV-13.

Releases here are cut by create-release.yml via the Forgejo API, and an API-created tag does NOT raise push: tags: v* (YOTUN-29), so a release: published trigger is added so the versioned release bundle is actually built.

Verification

Both workflow YAMLs parse; all embedded nu run: blocks pass nu --ide-check; the trigger-derived resolver was exercised for the release-event, tag-push, and main-push cases (release/tag -> vX.Y.Z, main -> latest). The change is confined to CI workflow YAML (no Rust/Bun/formatted source), so fmt/clippy/build/test are unaffected.

Refs GOV-13, GOV-16.

Rolls out the GOV-13 twin-trigger publish fix to this repo's desktop-bundle workflows (`build-desktop-linux.yml`, `build-desktop-windows.yml`). Part of GOV-16. ## Problem Both workflows resolved the Generic Packages path label (`version`) from `git describe`. A release commit is simultaneously a push to `main` and the tagged commit, so the main-push run and the tag/release run resolved the same `vX.Y.Z` path and raced to DELETE-then-PUT the same immutable generic-package file: `409 package file already exists`. A describe-derived label also published main builds that were N commits past a tag under the bare tag, freezing the `latest` train and clobbering the release artifact. ## Fix Resolve the path label from the trigger (`github.event_name` / `github.ref`), never from `git describe`: a release/tag build publishes under its semver tag; every other build is a `push: branches: main` build and publishes under the moving `latest` package. The two trains write disjoint paths, so they never collide. This matches the proven yotun desktop pattern and the forgejo-cli reference adopted in GOV-13. Releases here are cut by `create-release.yml` via the Forgejo API, and an API-created tag does NOT raise `push: tags: v*` (YOTUN-29), so a `release: published` trigger is added so the versioned release bundle is actually built. ## Verification Both workflow YAMLs parse; all embedded nu `run:` blocks pass `nu --ide-check`; the trigger-derived resolver was exercised for the release-event, tag-push, and main-push cases (release/tag -> `vX.Y.Z`, main -> `latest`). The change is confined to CI workflow YAML (no Rust/Bun/formatted source), so fmt/clippy/build/test are unaffected. Refs GOV-13, GOV-16.

David added 1 commit 2026-06-19 22:06:58 +02:00

fix(ci): derive desktop publish version from trigger, not git describe ... 40db0dee1c

The Linux and Windows desktop-build workflows resolved the Generic Packages path label from `git describe`. On a release commit (which is simultaneously a push to `main` and the tagged commit) the main-push run and the tag/release run resolved the identical `vX.Y.Z` path and raced to DELETE-then-PUT the same immutable generic-package file, producing `409 package file already exists`. A `git describe`-derived label also published main builds that were N commits past a tag under the bare tag, freezing the `latest` train and clobbering the release artifact.

Resolve the path label from the trigger instead: a release/tag build publishes under its semver tag; every other build is a `push: branches: main` build and publishes under the moving `latest` package. The two trains write disjoint paths, so they never collide.

Releases here are cut by create-release.yml via the Forgejo API, and an API-created tag does NOT raise `push: tags: v*` (YOTUN-29), so add a `release: published` trigger (matching yotun) so the versioned release bundle is actually built.

#GOV-13

David added 1 commit 2026-06-22 02:55:08 +02:00

Merge branch 'main' into fix/desktop-twin-trigger-publish bf76d8aaa1

David merged commit f33f41ed4b into main 2026-06-22 03:02:30 +02:00

David deleted branch fix/desktop-twin-trigger-publish 2026-06-22 03:02:30 +02:00

David referenced this pull request from a commit 2026-06-22 03:02:31 +02:00

Merge pull request 'fix(ci): derive desktop publish version from trigger to kill twin-publish race' (#391) from fix/desktop-twin-trigger-publish into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

psa-systems/lets-chat!391

No description provided.