psa-systems/lets-chat
Watch
9
0
Fork
You've already forked lets-chat
 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

fix(report): gate admin-queue helpers behind standalone (LC-22 / LC-334) #349

Merged
YousifShkara merged 1 commit from fix/lc-22-routes-reports-appstate-drift into main 2026-06-18 06:42:24 +02:00
Conversation 0 Commits 1 Files changed 1 +12 -3
YousifShkara commented 2026-06-18 06:42:21 +02:00
Owner
Copy link

CI's clippy on main now fails with -D dead-code because the admin-queue
helpers in routes/report.rs (build_report_views, render_reports_oob,
label_for, excerpt) have no callers in the saas build: their only call
sites (routes/admin.rs + ws.rs::render_admin_reports) are #[cfg(standalone)]
but the helpers were unguarded.

Mirror the gate on the helpers + their standalone-only view imports
(AdminReportsOob, ReportView). The submit-side handlers (get_report_modal,
post_report, broadcast_reports_changed) stay in both builds because they
are wired in routes/mod.rs unconditionally.

LC-334 shipped a few hours before the LC-22 cutover landed; the saas
clippy run did not surface this in CI before main accepted both. Fix
forward.

Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com

CI's clippy on main now fails with -D dead-code because the admin-queue helpers in routes/report.rs (build_report_views, render_reports_oob, label_for, excerpt) have no callers in the saas build: their only call sites (routes/admin.rs + ws.rs::render_admin_reports) are #[cfg(standalone)] but the helpers were unguarded. Mirror the gate on the helpers + their standalone-only view imports (AdminReportsOob, ReportView). The submit-side handlers (get_report_modal, post_report, broadcast_reports_changed) stay in both builds because they are wired in routes/mod.rs unconditionally. LC-334 shipped a few hours before the LC-22 cutover landed; the saas clippy run did not surface this in CI before main accepted both. Fix forward. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
fix(report): gate admin-queue helpers behind standalone (LC-22 / LC-334)
Some checks failed
check-secrets / TruffleHog (push) Successful in 4s
Details
check-secrets / Nosey parker (push) Successful in 2s
Details
check-secrets / Kingfisher (push) Successful in 5s
Details
Create release / Create release from merged PR (pull_request) Has been skipped
Details
check-secrets / Nosey parker (pull_request) Successful in 3s
Details
check-secrets / TruffleHog (pull_request) Successful in 4s
Details
check-secrets / Kingfisher (pull_request) Successful in 5s
Details
Check / clippy + fmt + tests (pull_request) Failing after 20s
Details
e22c95a2b0 
CI's clippy on main now fails with -D dead-code because the admin-queue
helpers in routes/report.rs (build_report_views, render_reports_oob,
label_for, excerpt) have no callers in the saas build: their only call
sites (routes/admin.rs + ws.rs::render_admin_reports) are #[cfg(standalone)]
but the helpers were unguarded.

Mirror the gate on the helpers + their standalone-only view imports
(AdminReportsOob, ReportView). The submit-side handlers (get_report_modal,
post_report, broadcast_reports_changed) stay in both builds because they
are wired in routes/mod.rs unconditionally.

LC-334 shipped a few hours before the LC-22 cutover landed; the saas
clippy run did not surface this in CI before main accepted both. Fix
forward.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
YousifShkara deleted branch fix/lc-22-routes-reports-appstate-drift 2026-06-18 06:42:24 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
YousifShkara
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/lets-chat!349
No description provided.