psa-systems/lets-chat
Watch
9
0
Fork
You've already forked lets-chat
 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

chore(ci): drop redundant apt install from Dockerfile.desktop-linux #101

Merged
David merged 2 commits from chore/desktop-linux-dockerfile-dedupe into main 2026-05-15 01:01:56 +02:00
Conversation 0 Commits 2 Files changed 1 -9
David commented 2026-05-15 01:00:56 +02:00
Owner
Copy link

Summary

The base image ghcr.io/niceguyit/rust-builder-glibc:v1.0.0-rust1.94-trixie already installs pkg-config, libgtk-3-dev, libwebkit2gtk-4.1-dev, libsoup-3.0-dev, and libssl-dev (see niceguyit/oci-images/rust-builder-glibc/Dockerfile). Reinstalling them here just slows the build, churns the apt layer cache, and risks drifting versions away from the base image when the base updates. Drop the redundant apt-get install block entirely.

Test plan

  • docker buildx build -f ci-build/Dockerfile.desktop-linux . succeeds end-to-end without the apt block (Wry+Tao link against the libraries the base image already provides).
  • The desktop-linux Forgejo workflow still produces a working lets-chat-desktop binary as the artifact.
## Summary The base image `ghcr.io/niceguyit/rust-builder-glibc:v1.0.0-rust1.94-trixie` already installs `pkg-config`, `libgtk-3-dev`, `libwebkit2gtk-4.1-dev`, `libsoup-3.0-dev`, and `libssl-dev` (see `niceguyit/oci-images/rust-builder-glibc/Dockerfile`). Reinstalling them here just slows the build, churns the apt layer cache, and risks drifting versions away from the base image when the base updates. Drop the redundant `apt-get install` block entirely. ## Test plan - [ ] `docker buildx build -f ci-build/Dockerfile.desktop-linux .` succeeds end-to-end without the apt block (Wry+Tao link against the libraries the base image already provides). - [ ] The desktop-linux Forgejo workflow still produces a working `lets-chat-desktop` binary as the artifact.
chore(ci): drop redundant apt install from Dockerfile.desktop-linux
Some checks failed
Check / clippy + fmt + tests (pull_request) Failing after 7s
Details
580c2ced98 
The base image `ghcr.io/niceguyit/rust-builder-glibc` already installs pkg-config, libgtk-3-dev, libwebkit2gtk-4.1-dev, libsoup-3.0-dev, and libssl-dev (see niceguyit/oci-images/rust-builder-glibc/Dockerfile). Reinstalling them here just slows the build, churns the apt layer cache, and risks drifting versions away from the base image when the base updates. Drop the redundant `apt-get install` block entirely.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Merge branch 'main' into chore/desktop-linux-dockerfile-dedupe
Some checks failed
Check / clippy + fmt + tests (pull_request) Failing after 11m18s
Details
aa3da4be1c
David merged commit 65dad3df38 into main 2026-05-15 01:01:56 +02:00
David deleted branch chore/desktop-linux-dockerfile-dedupe 2026-05-15 01:01:56 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/lets-chat!101
No description provided.