feat(admin): reorder applications with arrow icons instead of Up/Down text (BUNYIP-404) #405

Merged
longjacksonle merged 1 commit from feat/BUNYIP-404-reorder-arrow-icons into main 2026-07-29 00:41:45 +02:00

What

The application-management reorder controls rendered the literal words "Up" / "Down". Replaced the visible text with chevron-up / chevron-down arrow icons from the existing icon() helper. Added the chevron-up glyph (pairs with the chevron-down already in the set).

Unchanged

  • title and aria-label ("Move up" / "Move down") stay on both buttons - screen-reader label + tooltip preserved.
  • Each button is still a submit inside its own form posting to /admin/applications/{id}/swap-order; the sort_order swap logic is untouched. Only the button content changed.
  • Arrows are inline SVG, so no styles.css rebuild is involved.

Acceptance criteria

  • Reorder controls render as up/down arrow icon buttons, not the words "Up"/"Down".
  • title and aria-label remain present on both buttons.
  • Reordering still persists (form action/method/sort_order handling unchanged).

Verification

  • just check-container green: fmt + clippy -D warnings + all test binaries (122 web tests). Added a guard test that both chevron glyphs resolve to a real SVG path rather than the empty fallback (which would render a blank button).

🤖 Generated with Claude Code

## What The application-management reorder controls rendered the literal words "Up" / "Down". Replaced the visible text with `chevron-up` / `chevron-down` arrow icons from the existing `icon()` helper. Added the `chevron-up` glyph (pairs with the `chevron-down` already in the set). ## Unchanged - `title` and `aria-label` ("Move up" / "Move down") stay on both buttons - screen-reader label + tooltip preserved. - Each button is still a submit inside its own form posting to `/admin/applications/{id}/swap-order`; the `sort_order` swap logic is untouched. Only the button content changed. - Arrows are inline SVG, so no `styles.css` rebuild is involved. ## Acceptance criteria - [x] Reorder controls render as up/down arrow icon buttons, not the words "Up"/"Down". - [x] `title` and `aria-label` remain present on both buttons. - [x] Reordering still persists (form action/method/`sort_order` handling unchanged). ## Verification - `just check-container` green: fmt + clippy `-D warnings` + all test binaries (122 web tests). Added a guard test that both chevron glyphs resolve to a real SVG path rather than the empty fallback (which would render a blank button). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
feat(admin): reorder applications with arrow icons instead of "Up"/"Down" text (BUNYIP-404)
All checks were successful
E2E / Playwright against deployment (pull_request) Successful in 1m28s
Check / fmt + clippy + build + tests (pull_request) Successful in 8m13s
Create release / Create release from merged PR (pull_request) Has been skipped
a1e84de2d3
The application-management reorder controls showed the literal words "Up" / "Down". Replaced the visible text with the `chevron-up` / `chevron-down` icon glyphs from the existing `icon()` helper. Added the `chevron-up` glyph (it pairs with the `chevron-down` already in the set).

Behaviour and accessibility are unchanged: the `title` and `aria-label` ("Move up" / "Move down") stay on both buttons, and each remains a submit button in its own form posting to `/admin/applications/{id}/swap-order` with the unchanged `sort_order` swap - only the button content changed. The arrows are inline SVG (no stylesheet dependency).

Added a small guard test that both chevron glyphs resolve to a real SVG path rather than the empty-`inner` fallback (which would render a blank button).

Verified: `just check-container` green (fmt + clippy -D warnings + all test binaries, 122 web tests).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01L5dcYueNHByRnWJDYoDX1W
longjacksonle scheduled this pull request to auto merge when all checks succeed 2026-07-29 00:35:05 +02:00
longjacksonle deleted branch feat/BUNYIP-404-reorder-arrow-icons 2026-07-29 00:41:45 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/bunyip!405
No description provided.