psa-systems/bunyip
Watch
9
0
Fork
You've already forked bunyip
 0
Code Issues Pull requests Projects Releases 18 Packages Wiki Activity Actions

fix(e2e): fixme consent-screen + diagnose the /settings page-close (BUNYIP-148) #195

Merged
nrupard merged 1 commit from fix/BUNYIP-148-account-ui-and-consent into main 2026-06-22 22:23:19 +02:00
Conversation 0 Commits 1 Files changed 3 +18 -1
nrupard commented 2026-06-22 22:18:55 +02:00
Owner
Copy link

Login is fixed (DOM-set) - setup + auth round-trip + memberships + OIDC authorize + token-flow all pass. Two remaining:\n\n- consent-screen.spec: bare GET /oauth2/consent 404s (route only renders inside an in-flight authorize with un-granted scopes; the E2E accounts scopes are pre-granted in setup). Mark test.fixme (documented fallback; needs a throwaway client/scope).\n- profile + sessions: "page closed" on goto /settings (memberships passes). Add crash/pageerror/console listeners in beforeEach to name what closes the page on the next run.\n\ntsc clean.\n\n#BUNYIP-148

Login is fixed (DOM-set) - setup + auth round-trip + memberships + OIDC authorize + token-flow all pass. Two remaining:\n\n- consent-screen.spec: bare GET /oauth2/consent 404s (route only renders inside an in-flight authorize with un-granted scopes; the E2E accounts scopes are pre-granted in setup). Mark test.fixme (documented fallback; needs a throwaway client/scope).\n- profile + sessions: "page closed" on goto /settings (memberships passes). Add crash/pageerror/console listeners in beforeEach to name what closes the page on the next run.\n\ntsc clean.\n\n#BUNYIP-148
fix(e2e): fixme the consent-screen spec + diagnose the /settings page-close
Some checks failed
E2E / Playwright against deployment (pull_request) Failing after 53s
Details
Check / fmt + clippy + build + tests (pull_request) Successful in 4m21s
Details
Create release / Create release from merged PR (pull_request) Has been skipped
Details
d0672149a0 
After the DOM-set login fix landed, setup + auth round-trip + memberships + OIDC authorize-redirect + token-flow all pass. Two remaining:

- consent-screen.spec: a bare GET /oauth2/consent returns 404 (the route only renders inside an in-flight authorize with un-granted scopes), and the E2E account's scopes are pre-granted in global.setup, so there is no consent screen to assert. Mark test.fixme - the documented fallback in the file header; needs a throwaway client/scope (BUNYIP-148).

- profile.spec + sessions.spec fail with "page/context/browser has been closed" on goto /settings (memberships, same project + storageState, passes). Add crash/pageerror/console.error listeners in their beforeEach so the next run names what closes the page (likely a headless-shell crash rendering the heavier /settings page).

tsc --noEmit clean.

#BUNYIP-148

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
nrupard scheduled this pull request to auto merge when all checks succeed 2026-06-22 22:19:32 +02:00
nrupard deleted branch fix/BUNYIP-148-account-ui-and-consent 2026-06-22 22:23:19 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
psa-systems/bunyip!195
No description provided.