psa-systems/bunyip
8
0
Fork 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

fix(dev-sso): mark the per-developer private network external #19

Merged
longjacksonle merged 1 commit from fix/dev-sso-private-network-external into main 2026-05-31 18:55:50 +02:00
Conversation 0 Commits 1 Files changed 1 +5 -1
longjacksonle commented 2026-05-31 18:55:46 +02:00
Owner
Copy link

The dunite rewrite dropped external: true from the private network but the just dev* recipes still pre-create it with docker network create. Compose then expected to own the network and aborted on the pre-created one: "network dev-bunyip-private-${USER} was found but has incorrect label com.docker.compose.network set to '' (expected: private)". Restore external: true so compose attaches to the recipe-created network instead of trying to manage it, matching the recipe's comment and the pre-rewrite behaviour.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

The dunite rewrite dropped `external: true` from the `private` network but the `just dev*` recipes still pre-create it with `docker network create`. Compose then expected to own the network and aborted on the pre-created one: "network dev-bunyip-private-${USER} was found but has incorrect label com.docker.compose.network set to '' (expected: private)". Restore `external: true` so compose attaches to the recipe-created network instead of trying to manage it, matching the recipe's comment and the pre-rewrite behaviour. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
fix(dev-sso): mark the per-developer private network external
Some checks failed
Create release / Create release from merged PR (pull_request) Has been skipped
Details
Check / fmt / clippy / build / test (pull_request) Failing after 4s
Details
820516b55e 
The dunite rewrite dropped `external: true` from the `private` network but the `just dev*` recipes still pre-create it with `docker network create`. Compose then expected to own the network and aborted on the pre-created one: "network dev-bunyip-private-${USER} was found but has incorrect label com.docker.compose.network set to '' (expected: private)". Restore `external: true` so compose attaches to the recipe-created network instead of trying to manage it, matching the recipe's comment and the pre-rewrite behaviour.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
longjacksonle deleted branch fix/dev-sso-private-network-external 2026-05-31 18:55:51 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
psa-systems/bunyip!19
No description provided.