chore(common): bump the common submodule to 4de5dfa and adopt the tree-ownership guard #149

Merged

David merged 1 commit from chore/GOV-45-update-common-submodule into main

2026-08-08 02:33:31 +02:00

David commented

2026-08-08 01:18:18 +02:00

Owner

Bumps the common submodule gitlink from d424d6a to 4de5dfa (current psa-systems/common main) and ports the new tree-ownership guard into this repo's pre-commit override. Part of the cross-repo sync tracked in GOV-45.

What the new pin brings in: the dev_extra_volumes variable on dev-clean, the virtual-workspace release layout, the reusable check workflow's runner-label switch to RUNS_ON_OPENSUSE_DEV_LATEST and its compile_step / test_args / cache inputs, the nu line-continuation fix in build-docker-export, and the check-tree-ownership recipe.

youtrack-cli overrides pre-commit so the toolchain matches CI exactly, so the guard common added inside its own pre-commit-docker does not reach this repo through the gitlink alone. It is ported into the override: just check-tree-ownership runs after the test step and fails the commit if any path in the working tree is not owned by the host user, which is the DEV-371 regression where a containerized step running as root leaves files needing sudo to remove. CLAUDE.md's CI-parity section is updated in the same commit, since the recipe is no longer a step-for-step mirror of check.yml alone.

Not applicable here: default is already the first recipe; the release layout is already workspace with release_manifest := "crates/yt-cli/Cargo.toml", and the root manifest carries no [workspace.package] version, so virtual-workspace does not apply; compose.dev.yml declares only the three cargo volumes, which common's dev-clean already removes, so dev_extra_volumes has nothing to add; and youtrack-cli ships its own check.yml rather than calling the shared workflow.

Verification: just pre-commit passes on the new pin (fmt, clippy, build, 53 tests, and check-tree-ownership reports the working tree fully owned by the host user).

#GOV-45

Bumps the `common` submodule gitlink from `d424d6a` to `4de5dfa` (current `psa-systems/common` `main`) and ports the new tree-ownership guard into this repo's `pre-commit` override. Part of the cross-repo sync tracked in GOV-45. What the new pin brings in: the `dev_extra_volumes` variable on `dev-clean`, the `virtual-workspace` release layout, the reusable check workflow's runner-label switch to `RUNS_ON_OPENSUSE_DEV_LATEST` and its `compile_step` / `test_args` / `cache` inputs, the nu line-continuation fix in `build-docker-export`, and the `check-tree-ownership` recipe. youtrack-cli overrides `pre-commit` so the toolchain matches CI exactly, so the guard common added inside its own `pre-commit-docker` does not reach this repo through the gitlink alone. It is ported into the override: `just check-tree-ownership` runs after the test step and fails the commit if any path in the working tree is not owned by the host user, which is the DEV-371 regression where a containerized step running as root leaves files needing `sudo` to remove. CLAUDE.md's CI-parity section is updated in the same commit, since the recipe is no longer a step-for-step mirror of `check.yml` alone. Not applicable here: `default` is already the first recipe; the release layout is already `workspace` with `release_manifest := "crates/yt-cli/Cargo.toml"`, and the root manifest carries no `[workspace.package] version`, so `virtual-workspace` does not apply; `compose.dev.yml` declares only the three cargo volumes, which common's `dev-clean` already removes, so `dev_extra_volumes` has nothing to add; and youtrack-cli ships its own `check.yml` rather than calling the shared workflow. Verification: `just pre-commit` passes on the new pin (fmt, clippy, build, 53 tests, and `check-tree-ownership` reports the working tree fully owned by the host user). #GOV-45

David added 1 commit

2026-08-08 01:18:18 +02:00

chore(common): bump the common submodule to 4de5dfa and adopt the tree-ownership guard

Check / fmt + clippy + build + tests (pull_request) Successful in 2m26s

Details

Create release / Create release from merged PR (pull_request) Has been skipped

Details

21bba0d7c9

Moves the `common` gitlink from d424d6a to 4de5dfa, picking up the `dev_extra_volumes` variable on `dev-clean`, the `virtual-workspace` release layout, the runner-label switch to RUNS_ON_OPENSUSE_DEV_LATEST in the reusable check workflow, the nu line-continuation fix in `build-docker-export`, and the `check-tree-ownership` guard.

youtrack-cli overrides `pre-commit` so the toolchain matches CI exactly, which means the guard common added to its own variants does not reach this repo by the gitlink alone; it is ported into the override here. It fails the commit if any path in the working tree is not owned by the host user, catching the DEV-371 regression where a containerized step running as root leaves files that need sudo to remove. CLAUDE.md's CI-parity section is updated to name the extra step, since the recipe is no longer a step-for-step mirror of check.yml alone.

`default` is already the first recipe, the workspace release layout is already set (`release_layout := "workspace"` with `release_manifest := "crates/yt-cli/Cargo.toml"`; the root manifest has no `[workspace.package] version`, so `virtual-workspace` does not apply), and compose.dev.yml declares only cargo volumes, so `dev_extra_volumes` has nothing to add.

#GOV-45