chore: remove em-dashes per repo style #12

Merged

David merged 1 commit from chore/em-dash-sweep into main

2026-05-14 00:23:52 +02:00

David commented

2026-05-14 00:21:36 +02:00

Owner

Removes every U+2014 em-dash from the repo per the no-em-dash style rule. 40 substitutions across 7 files; no behavior change.

Substitution rules

The replacement was chosen per call site, never globally:

x — explanation -> x: explanation when the second half expands the first.
x — independent clause -> x; independent clause when the second half is a full thought.
Title — Subtitle (heading) -> Title: Subtitle.
x — Y inside an embedded reference like via use super::*; — the ... -> split into two sentences (... ;. Change to ...) to avoid ;: / ;; ugliness.
Bullet item path — description -> path: description.

Files

src/main.rs, src/image/mod.rs, src/video/convert.rs: doc comments and inline comments.
src/video/convert.rs:373: the bail! error string changes from "... — install ..." to "... . Install ...". No test asserts the exact text; the only other reference is a comment in the plan doc, which is updated to match.
oci-build/get-tags.nu, .forgejo/workflows/create-release.yml: single-line comments.
docs/superpowers/specs/2026-04-16-video-conversion-design.md, docs/superpowers/plans/2026-04-16-video-conversion.md: historical design and plan docs. Em-dashes replaced in place; eyes references are left as-is since these docs are dated and self-evidently historical (the rename to monkey post-dates them).

Verification

grep -rn '—' --exclude-dir=target --exclude-dir=.git --exclude-dir=.claude . returns nothing.
git diff --stat reports 40 insertions / 40 deletions; pure 1:1 substitution.

Test plan

just pre-commit (Docker-based) passes fmt + clippy + build + tests.
just check-docker builds.
Forgejo Check workflow stays green on this PR.

Removes every U+2014 em-dash from the repo per the no-em-dash style rule. 40 substitutions across 7 files; no behavior change. ## Substitution rules The replacement was chosen per call site, never globally: - `x — explanation` -> `x: explanation` when the second half expands the first. - `x — independent clause` -> `x; independent clause` when the second half is a full thought. - `Title — Subtitle` (heading) -> `Title: Subtitle`. - `x — Y` inside an embedded reference like `via use super::*; — the ...` -> split into two sentences (`... ;. Change to ...`) to avoid `;: ` / `;; ` ugliness. - Bullet item `path — description` -> `path: description`. ## Files - `src/main.rs`, `src/image/mod.rs`, `src/video/convert.rs`: doc comments and inline comments. - `src/video/convert.rs:373`: the `bail!` error string changes from `"... — install ..."` to `"... . Install ..."`. No test asserts the exact text; the only other reference is a comment in the plan doc, which is updated to match. - `oci-build/get-tags.nu`, `.forgejo/workflows/create-release.yml`: single-line comments. - `docs/superpowers/specs/2026-04-16-video-conversion-design.md`, `docs/superpowers/plans/2026-04-16-video-conversion.md`: historical design and plan docs. Em-dashes replaced in place; `eyes` references are left as-is since these docs are dated and self-evidently historical (the rename to `monkey` post-dates them). ## Verification - `grep -rn '—' --exclude-dir=target --exclude-dir=.git --exclude-dir=.claude .` returns nothing. - `git diff --stat` reports 40 insertions / 40 deletions; pure 1:1 substitution. ## Test plan - [ ] `just pre-commit` (Docker-based) passes fmt + clippy + build + tests. - [ ] `just check-docker` builds. - [ ] Forgejo `Check` workflow stays green on this PR.

David added 1 commit

2026-05-14 00:21:36 +02:00

chore: remove em-dashes per repo style

Check / fmt + clippy + build + tests (pull_request) Failing after 5s

Details

Create release / Create release from merged PR (pull_request) Has been skipped

Details

7baa8eaf59

Replace U+2014 em-dashes with regular hyphens, colons, semicolons, parentheses, or sentence breaks across source comments, doc comments, one error string, one workflow comment, one Nushell comment, and the two superpowers design/plan docs. No behavior change. The only string literal touched is the ffmpeg-not-found `bail!` message in src/video/convert.rs, which now reads "ffmpeg not found on PATH. Install ffmpeg and try again" - no test asserts the exact text.

40 lines changed, 1:1 substitutions per line. The replacement chosen per call site:

- `x — explanation` -> `x: explanation` (colon when explanation expands the prior clause).
- `x — independent clause` -> `x; independent clause` (semicolon when the second half is a full thought).
- `x — Y` at end-of-line in a multi-line block -> `x: Y` or `x; Y` per fit.
- `Title — Subtitle` -> `Title: Subtitle`.
- Inline `... ; — change to ...` -> `... ;. Change to ...` (split into two sentences to avoid `;: ` or `;; `).

No em-dashes remain anywhere outside `.git`, `target`, and `.claude`.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>